Update validTest() : Simplify logic, clarify vars and add comments

diff --git a/qunit/qunit.js b/qunit/qunit.js
index 2b60fbd..c681aba 100644 (file)
--- a/qunit/qunit.js
+++ b/qunit/qunit.js
@@ -1000,29 +1000,26 @@ function done() {
 }
 
 function validTest( name ) {
-       var not,
-               filter = config.filter,
-               run = false;
+       var include,
+               filter = config.filter;
 
+       // By default, run all tests
        if ( !filter ) {
                return true;
        }
 
-       not = filter.charAt( 0 ) === "!";
-
-       if ( not ) {
+       include = filter.charAt( 0 ) !== "!";
+       if ( !include ) {
                filter = filter.slice( 1 );
        }
 
+       // If the filter matches, we need to honour include
        if ( name.indexOf( filter ) !== -1 ) {
-               return !not;
-       }
-
-       if ( not ) {
-               run = true;
+               return include;
        }
 
-       return run;
+       // Otherwise, do the opposite
+       return !include;
 }
 
 // so far supports only Firefox, Chrome and Opera (buggy), Safari (for real exceptions)